stanlemon•net

I patched your code to proper recognize IE7, while it recognize IE7 as IE6.
It's not your bug, this is a public bug...

In jquery.jgrowl.js line 200 you have this:

if ($.browser.msie && parseInt($.browser.version) < 7) $(this.element).addClass('ie6');

BEFORE this line i add this and work perfectly:

if(jQuery.browser.msie && parseInt(jQuery.browser.version) == 6 && window["XMLHttpRequest"] ) {
jQuery.browser.version = "7.0"
}

(sorry my bad english...)

Hope i help,
BD-Team
http://www.bdteam.hu

on jGrowl:

Thanks for saving me a lot of time:)

I have one apparent bug, and two suggestions.

The bug: It seems the script checks for an option named 'corner', while your documentation mentions an option named 'corners'.

The suggestions:
You may want to clearly mention that some settings only work when you set them as defaults, not when you hand them to $.jGrowl(), and explain how to change those defaults.

Also: renaming the CSS class 'header' to something less likely to collide with people's own classes may avoid some confusion.


on the jGrowl feedback form:
It's broken :)

Bart,
The preference is actually "corners", but in order for it to be used it tests for the presence of $.fn.corner . This is probably a little confusing when looking at the source, but the documentation is actually correct. It also should probably be renamed, but now I have to keep it for compatibility sake.

The same goes for the CSS class'es, I agree with you 120% about the naming, and I wish I had done things differently. However, enough people are using the script now that to change it would break a bunch of existing installations. I'll probably look to add some alternative and better named classes in the future, or perhaps even a compat-mode like I did with the general $.jGrowl() wrapper method down the road.

Thanks for the feedback, I appreciate it!

- SL

Hi Stan,

I love jgrowl, it's a masterpiece.

One quick tip: the .zip file contains the Mac resource forks, and the one for smoke.png is over 100k compressed. If you used Stuffit to create the zip file, it wouldn't include that resource fork, and the download package would decrease in size by over 100k.

Peter

PS: the previous commenter was right -- your contact form doesn't work..

Thanks for letting me know about the contact form, I missed it in the earlier comment. I believe that's fixed and working properly now.

Also, thanks for the tip on using Stuffit! I will make sure to do this with the next release.

- SL

This works great, a suggestion though, you should include BD-Team's fix for IE7, it works perfectly!

Thanks for jGrowl, and thanks bd-team for your code fix for IE7! I've been ripping my hair out for a week over that problem!!

I did however have to swap your fix around for it to work...

if(jQuery.browser.msie && parseInt(jQuery.browser.version) == 7 && window["XMLHttpRequest"] ) {
jQuery.browser.version = "6.0"
}

Not sure if that's correct or not, but it fixed my problem! :)

I tried it both ways and I cant get it to work on IE7 at all??

I am getting an INVALID ARGUMENT ERROR??? any ideas.